fix(voice): finish STT event handling after listener errors - #4170
Merged
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b5f6e8f872
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
seratch
enabled auto-merge (squash)
August 4, 2026 06:47
This was referenced Aug 5, 2026
abhay-codes07
added a commit
to abhay-codes07/openai-agents-python
that referenced
this pull request
Aug 5, 2026
Three streaming dispatchers hand user events to a background task and then wait for asyncio.Queue.join() before returning. Each dispatcher catches only Exception, so a handler raising a BaseException -- CancelledError being the realistic one, from a timeout or cancellation inside the callback -- kills the consumer. The outstanding task_done() calls can then never arrive and join() blocks forever, hanging the run with no error and no timeout. In every case join() is also redundant. The sentinel is queued last and the consumer only returns after consuming it, so awaiting the consumer task already implies every event was handled, and it surfaces a dead consumer instead of waiting on it. - Agent.as_tool(on_stream=...) hung the tool invocation. - Codex tool _consume_events() hung and left its tracing spans unfinished, because the span cleanup runs after the join. - The sandbox memory manager flush hung before its phase-two consolidation. Same failure shape as the STT listener fix in openai#4170.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a Python 3.10 and 3.11 test slowdown caused by streamed STT error cleanup waiting for the event inactivity timeout.
The websocket listener now always notifies the event consumer when it exits, including error and cancellation paths. This allows the event-processing task to finish promptly while preserving the existing terminal
STTWebsocketConnectionErrorbehavior. The regression test verifies that server errors emit the websocket completion marker and leave the event-processing task finished.